Comments on: Competition “Laugh or cry?” http://erka.kpumuk.info/development/competition-laugh-or-cry/ Wed, 19 Nov 2008 11:47:42 +0000 http://wordpress.org/?v=2.5.1 By: exitTeam http://erka.kpumuk.info/development/competition-laugh-or-cry/#comment-14700 exitTeam Tue, 30 Nov 2010 00:00:00 +0000 http://erka.kpumuk.info/development/competition-laugh-or-cry/#comment-14700 Hi, As for me the best one is Dmytro Shteflyuk's example with date validation. Btw, small addition to the leap year validation, it should be checked if it is divisible to 4, and not divisible to 100, but, if it is divisible to 400 then it is a leap year too :) also some small todays example: <code lang="PHP">ini_set('session.timeout', 28800);</code> hope you will like it :) Hi,
As for me the best one is Dmytro Shteflyuk’s example with date validation.
Btw, small addition to the leap year validation, it should be checked if it is divisible to 4, and not divisible to 100, but, if it is divisible to 400 then it is a leap year too :)

also some small todays example:

ini_set('session.timeout', 28800);

hope you will like it :)

]]> By: COTOHA http://erka.kpumuk.info/development/competition-laugh-or-cry/#comment-11912 COTOHA Tue, 30 Nov 2010 00:00:00 +0000 http://erka.kpumuk.info/development/competition-laugh-or-cry/#comment-11912 флудя в блоге ты, эрка, не остановишь волну народного гнева. обманутый народ, он, знаешь ли, беспощаден... флудя в блоге ты, эрка, не остановишь волну народного гнева. обманутый народ, он, знаешь ли, беспощаден…

]]> By: COTOHA http://erka.kpumuk.info/development/competition-laugh-or-cry/#comment-11829 COTOHA Sun, 30 Nov 2008 00:00:00 +0000 http://erka.kpumuk.info/development/competition-laugh-or-cry/#comment-11829 осталось только показать как этот SQL оптимизируется... потому как если нет, то что тут такого? просто бокс - сложный спорт и требует сложных SQL'ей. :) осталось только показать как этот SQL оптимизируется… потому как если нет, то что тут такого? просто бокс - сложный спорт и требует сложных SQL’ей. :)

]]> By: erka http://erka.kpumuk.info/development/competition-laugh-or-cry/#comment-11814 erka Wed, 30 Nov 2011 00:00:00 +0000 http://erka.kpumuk.info/development/competition-laugh-or-cry/#comment-11814 Oooo... I have never seen a sql query like posted one. Oooo… I have never seen a sql query like posted one.

]]> By: Alexey Kovyrin http://erka.kpumuk.info/development/competition-laugh-or-cry/#comment-11813 Alexey Kovyrin Tue, 30 Nov 2010 00:00:00 +0000 http://erka.kpumuk.info/development/competition-laugh-or-cry/#comment-11813 While optimizing some customer application I've found following SQL query: <code lang="sql"> (SELECT country_code, region_name, towncity_name, venue_name, ticketing_number, shows.show_id, date, commission_id, locked, bouts.user, inserter, bouts.bout_id, rounds_scheduled, rounds_boxed, decision, bouts.division , result, time, boxer_a_id, boxer_a_weight, boxer_a.dob as boxer_a_dob, boxer_a.last_name as boxer_a_last_name, boxer_a.first_name as boxer_a_first_name, boxer_b_id, boxer_b_weight, boxer_b.dob as boxer_b_dob, boxer_b.last_name as boxer_b_last_name, boxer_b.first_name as boxer_b_first_name, judge1, jdg1_pts_a, jdg1_pts_b, judge1.last_name as judge1_last_name, judge1.first_name as judge1_first_name, judge2, jdg2_pts_a, jdg2_pts_b, judge2.last_name as judge2_last_name, judge2.first_name as judge2_first_name, judge3, jdg3_pts_a, jdg3_pts_b, judge3.last_name as judge3_last_name, judge3.first_name as judge3_first_name, referee, ref_pts_a, ref_pts_b, referee.last_name as referee_last_name, referee.first_name as referee_first_name FROM bouts JOIN shows ON bouts.show_id = shows.show_id JOIN venues ON shows.venue_id = venues.venue_id JOIN towncities ON venues.towncity_id = towncities.towncity_id JOIN humans AS boxer_a ON boxer_a.human_id = bouts.boxer_a_id JOIN humans AS boxer_b ON boxer_b.human_id = bouts.boxer_b_id JOIN humans AS referee ON referee.human_id = bouts.referee JOIN humans AS judge1 ON judge1.human_id = bouts.judge1 JOIN humans AS judge2 ON judge2.human_id = bouts.judge2 JOIN humans AS judge3 ON judge3.human_id = bouts.judge3 WHERE (boxer_b_id = '001616') AND result = 'SC') UNION (SELECT country_code, region_name, towncity_name, venue_name, ticketing_number, shows.show_id, date, commission_id, locked, bouts.user, inserter, bouts.bout_id, rounds_scheduled, rounds_boxed, decision, bouts.division , result, time, boxer_a_id, boxer_a_weight, boxer_a.dob as boxer_a_dob, boxer_a.last_name as boxer_a_last_name, boxer_a.first_name as boxer_a_first_name, boxer_b_id, boxer_b_weight, boxer_b.dob as boxer_b_dob, boxer_b.last_name as boxer_b_last_name, boxer_b.first_name as boxer_b_first_name, judge1, jdg1_pts_a, jdg1_pts_b, judge1.last_name as judge1_last_name, judge1.first_name as judge1_first_name, judge2, jdg2_pts_a, jdg2_pts_b, judge2.last_name as judge2_last_name, judge2.first_name as judge2_first_name, judge3, jdg3_pts_a, jdg3_pts_b, judge3.last_name as judge3_last_name, judge3.first_name as judge3_first_name, referee, ref_pts_a, ref_pts_b, referee.last_name as referee_last_name, referee.first_name as referee_first_name FROM bouts JOIN shows ON bouts.show_id = shows.show_id JOIN venues ON shows.venue_id = venues.venue_id JOIN towncities ON venues.towncity_id = towncities.towncity_id JOIN humans AS boxer_a ON boxer_a.human_id = bouts.boxer_a_id JOIN humans AS boxer_b ON boxer_b.human_id = bouts.boxer_b_id JOIN humans AS referee ON referee.human_id = bouts.referee JOIN humans AS judge1 ON judge1.human_id = bouts.judge1 JOIN humans AS judge2 ON judge2.human_id = bouts.judge2 JOIN humans AS judge3 ON judge3.human_id = bouts.judge3 WHERE (boxer_a_id = '001616') AND result = 'SC') ORDER BY date DESC; </code> While optimizing some customer application I’ve found following SQL query:

(SELECT
          country_code, region_name, towncity_name, venue_name, ticketing_number,
          shows.show_id, date, commission_id, locked, bouts.user, inserter,
          bouts.bout_id, rounds_scheduled, rounds_boxed, decision, bouts.division , result, time,
          boxer_a_id,
          boxer_a_weight,
          boxer_a.dob AS boxer_a_dob,
          boxer_a.last_name AS boxer_a_last_name,
          boxer_a.first_name AS boxer_a_first_name,
          boxer_b_id,
          boxer_b_weight,
          boxer_b.dob AS boxer_b_dob,
          boxer_b.last_name AS boxer_b_last_name,
          boxer_b.first_name AS boxer_b_first_name,
          judge1,
          jdg1_pts_a,
          jdg1_pts_b,
          judge1.last_name AS judge1_last_name,
          judge1.first_name AS judge1_first_name,
          judge2,
          jdg2_pts_a,
          jdg2_pts_b,
          judge2.last_name AS judge2_last_name,
          judge2.first_name AS judge2_first_name,
          judge3,
          jdg3_pts_a,
          jdg3_pts_b,
          judge3.last_name AS judge3_last_name,
          judge3.first_name AS judge3_first_name,
          referee,
          ref_pts_a,
          ref_pts_b,
          referee.last_name AS referee_last_name,
          referee.first_name AS referee_first_name
         FROM bouts
         JOIN shows ON bouts.show_id = shows.show_id
         JOIN venues ON shows.venue_id = venues.venue_id
         JOIN towncities ON venues.towncity_id = towncities.towncity_id
         JOIN humans AS boxer_a ON boxer_a.human_id = bouts.boxer_a_id
         JOIN humans AS boxer_b ON boxer_b.human_id = bouts.boxer_b_id
         JOIN humans AS referee ON referee.human_id = bouts.referee
         JOIN humans AS judge1 ON judge1.human_id = bouts.judge1
         JOIN humans AS judge2 ON judge2.human_id = bouts.judge2
         JOIN humans AS judge3 ON judge3.human_id = bouts.judge3
         WHERE
         (boxer_b_id = '001616') AND result = 'SC') UNION (SELECT
          country_code, region_name, towncity_name, venue_name, ticketing_number,
          shows.show_id, date, commission_id, locked, bouts.user, inserter,
          bouts.bout_id, rounds_scheduled, rounds_boxed, decision, bouts.division , result, time,
          boxer_a_id,
          boxer_a_weight,
          boxer_a.dob AS boxer_a_dob,
          boxer_a.last_name AS boxer_a_last_name,
          boxer_a.first_name AS boxer_a_first_name,
          boxer_b_id,
          boxer_b_weight,
          boxer_b.dob AS boxer_b_dob,
          boxer_b.last_name AS boxer_b_last_name,
          boxer_b.first_name AS boxer_b_first_name,
          judge1,
          jdg1_pts_a,
          jdg1_pts_b,
          judge1.last_name AS judge1_last_name,
          judge1.first_name AS judge1_first_name,
          judge2,
          jdg2_pts_a,
          jdg2_pts_b,
          judge2.last_name AS judge2_last_name,
          judge2.first_name AS judge2_first_name,
          judge3,
          jdg3_pts_a,
          jdg3_pts_b,
          judge3.last_name AS judge3_last_name,
          judge3.first_name AS judge3_first_name,
          referee,
          ref_pts_a,
          ref_pts_b,
          referee.last_name AS referee_last_name,
          referee.first_name AS referee_first_name
         FROM bouts
         JOIN shows ON bouts.show_id = shows.show_id
         JOIN venues ON shows.venue_id = venues.venue_id
         JOIN towncities ON venues.towncity_id = towncities.towncity_id
         JOIN humans AS boxer_a ON boxer_a.human_id = bouts.boxer_a_id
         JOIN humans AS boxer_b ON boxer_b.human_id = bouts.boxer_b_id
         JOIN humans AS referee ON referee.human_id = bouts.referee
         JOIN humans AS judge1 ON judge1.human_id = bouts.judge1
         JOIN humans AS judge2 ON judge2.human_id = bouts.judge2
         JOIN humans AS judge3 ON judge3.human_id = bouts.judge3
         WHERE
         (boxer_a_id = '001616') AND result = 'SC') ORDER BY date DESC;
]]> By: COTOHA http://erka.kpumuk.info/development/competition-laugh-or-cry/#comment-11774 COTOHA Sun, 30 Nov 2003 00:00:00 +0000 http://erka.kpumuk.info/development/competition-laugh-or-cry/#comment-11774 At the end of the third week five finalists will be selected from all participating examples and everyone will be able to vote for the most worse code during a week (August 10 — August 16). обман? ерка.... At the end of the third week five finalists will be selected from all participating examples and everyone will be able to vote for the most worse code during a week (August 10 — August 16).
обман? ерка….

]]> By: Dmytro Shteflyuk http://erka.kpumuk.info/development/competition-laugh-or-cry/#comment-11772 Dmytro Shteflyuk Fri, 30 Nov 2001 00:00:00 +0000 http://erka.kpumuk.info/development/competition-laugh-or-cry/#comment-11772 Собственно и где же голосование? :-) Кажись провтыкали Собственно и где же голосование? :-) Кажись провтыкали

]]> By: COTOHA http://erka.kpumuk.info/development/competition-laugh-or-cry/#comment-11654 COTOHA Thu, 30 Nov 2006 00:00:00 +0000 http://erka.kpumuk.info/development/competition-laugh-or-cry/#comment-11654 такое я тоже люблю: <code lang="java">if (logger.isDebugEnabled()) { logger.debug("Result = [" + result + "]"); }</code> повбивав би. такое я тоже люблю:

if (logger.isDebugEnabled()) {
    logger.debug("Result = [" + result + "]");
}

повбивав би.

]]> By: erka http://erka.kpumuk.info/development/competition-laugh-or-cry/#comment-11646 erka Thu, 30 Nov 2000 00:00:00 +0000 http://erka.kpumuk.info/development/competition-laugh-or-cry/#comment-11646 Вот вершина мастерства.. метод напрямую вызывается через web services. Интересно, какая вероятность того, что я это сломаю? Language: <em>Java</em> <code lang="java"> public Collection searchFreePID(String sql, String[] fields, String tableName, SearchFilter searchFilter) { logger.debug("#searchFreePID:enter"); Collection result = null; try { if (tableName != null) { Pattern p = Pattern.compile("\\s*(SELECT\\s+)(.+)", Pattern.CASE_INSENSITIVE); Matcher m = p.matcher(sql); if (m.find()) { sql = m.group(1) + OBLIGATORY_FIELDS + m.group(2); StringBuffer buffer = new StringBuffer(); buffer.append(sql); if (sql.indexOf("where") < 1) { buffer.append(" WHERE "); } buffer.append(" pid <> oid and pid = "); if (searchFilter.getPid() != null) { buffer.append(searchFilter.getPid()); } else { buffer.append("-1"); } sql = buffer.toString(); logger.debug("#sql = [" + sql + "]"); result = gFactory.selectFreeAll(sql, fields); } } } catch (Exception e) { logger.error("Exception in #searchAll", e); } if (logger.isDebugEnabled()) { logger.debug("Result = [" + result + "]"); } logger.debug("#searchFreePID:exit"); return result; } </code> Вот вершина мастерства.. метод напрямую вызывается через web services. Интересно, какая вероятность того, что я это сломаю?

Language: Java

public Collection searchFreePID(String sql, String[] fields, String tableName, SearchFilter searchFilter) {
        logger.debug("#searchFreePID:enter");
        Collection result = null;
        try {
            if (tableName != null) {
                Pattern p = Pattern.compile("\\s*(SELECT\\s+)(.+)", Pattern.CASE_INSENSITIVE);
                Matcher m = p.matcher(sql);
                if (m.find()) {
                    sql = m.group(1) + OBLIGATORY_FIELDS + m.group(2);
                    StringBuffer buffer = new StringBuffer();
                    buffer.append(sql);
                    if (sql.indexOf("where") < 1) {
                        buffer.append(" WHERE ");
                    }
                    buffer.append(" pid <> oid and pid = ");
                    if (searchFilter.getPid() != null) {
                        buffer.append(searchFilter.getPid());
                    } else {
                        buffer.append("-1");
                    }
                    sql = buffer.toString();
                    logger.debug("#sql = [" + sql + "]");
                    result = gFactory.selectFreeAll(sql, fields);
                }
            }
        } catch (Exception e) {
            logger.error("Exception in #searchAll", e);
        }
        if (logger.isDebugEnabled()) {
            logger.debug("Result = [" + result + "]");
        }
        logger.debug("#searchFreePID:exit");
        return result;
    }
]]> By: COTOHA http://erka.kpumuk.info/development/competition-laugh-or-cry/#comment-11642 COTOHA Tue, 30 Nov 2010 00:00:00 +0000 http://erka.kpumuk.info/development/competition-laugh-or-cry/#comment-11642 ого. тяжолое детсво :) я до сих пор так кол-во дней в месяце проверяю :) а почему понравился в кавычках? если по отношению к коду я ещё кавычки пойму, то к истории... так. ну а критики конечно выдать могу больше я. можем проверить, если как-то формализовать правила проверки... но учти, что я их раскритикую! ого. тяжолое детсво :) я до сих пор так кол-во дней в месяце проверяю :) а почему понравился в кавычках? если по отношению к коду я ещё кавычки пойму, то к истории…

так. ну а критики конечно выдать могу больше я. можем проверить, если как-то формализовать правила проверки… но учти, что я их раскритикую!

]]>